Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove href-no-hash Rule #114

Merged
merged 1 commit into from
Mar 2, 2019
Merged

Remove href-no-hash Rule #114

merged 1 commit into from
Mar 2, 2019

Conversation

mikeselander
Copy link
Contributor

As @ntwb pointed out in #101, we should now remove the href-no-hash rule as eslint-config-react-app updated their dependencies quite a while ago so this rule should no longer be needed.

Ref: facebook/create-react-app#2690

⚠️ this is built on top of #101 and that will need to be merged first.

@mikeselander mikeselander added this to the 0.6 milestone Dec 18, 2018
@mikeselander mikeselander mentioned this pull request Feb 15, 2019
Closed
@mikeselander mikeselander changed the base branch from update-peer-dependencies to master March 2, 2019 05:49
@mikeselander mikeselander merged commit c77a612 into master Mar 2, 2019
@mikeselander mikeselander deleted the remove-href-no-hash-rule branch March 2, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb ntwb approved these changes

@joehoyle joehoyle joehoyle approved these changes

@rmccue rmccue Awaiting requested review from rmccue

@kadamwhite kadamwhite Awaiting requested review from kadamwhite

Assignees
No one assigned
Labels
reviewer needed
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeselander @joehoyle @ntwb